search

Civcraft / RealisticBiomes

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/RealisticBiomes
7 stars 14 forks source link

Added two overrides to main plugin class. #19

Closed plebes closed 9 years ago

plebes commented 9 years ago

I added an override to onEnable() and onDisable(), which is standard practice. These functions originate at org.bukkit.plugin.

I know this is minor, but I want to fix anything I see wrong.

ttk2 commented 9 years ago

should this go on Civtest or do I want to wait for other minor fixes and do them all at once?

On Fri, May 29, 2015 at 11:24 PM erocs notifications@github.com wrote:

Merged #19 https://github.com/Civcraft/RealisticBiomes/pull/19.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/pull/19#event-317780909.

erocs commented 9 years ago

It doesn't need testing. On May 30, 2015 6:57 AM, "ttk2" notifications@github.com wrote:

should this go on Civtest or do I want to wait for other minor fixes and do them all at once?

On Fri, May 29, 2015 at 11:24 PM erocs notifications@github.com wrote:

Merged #19 https://github.com/Civcraft/RealisticBiomes/pull/19.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/pull/19#event-317780909.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/pull/19#issuecomment-107043292 .

ttk2 commented 9 years ago

none of these fixes need testing?

On Sat, May 30, 2015 at 4:15 PM erocs notifications@github.com wrote:

It doesn't need testing. On May 30, 2015 6:57 AM, "ttk2" notifications@github.com wrote:

should this go on Civtest or do I want to wait for other minor fixes and do them all at once?

On Fri, May 29, 2015 at 11:24 PM erocs notifications@github.com wrote:

Merged #19 https://github.com/Civcraft/RealisticBiomes/pull/19.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/pull/19#event-317780909.

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/RealisticBiomes/pull/19#issuecomment-107043292

.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/pull/19#issuecomment-107087111 .

erocs commented 9 years ago

Specifically this one doesn't. Wait on other fixes before bothering to move it live.

On Sat, May 30, 2015 at 5:41 PM, ttk2 notifications@github.com wrote:

none of these fixes need testing?

On Sat, May 30, 2015 at 4:15 PM erocs notifications@github.com wrote:

It doesn't need testing. On May 30, 2015 6:57 AM, "ttk2" notifications@github.com wrote:

should this go on Civtest or do I want to wait for other minor fixes and do them all at once?

On Fri, May 29, 2015 at 11:24 PM erocs notifications@github.com wrote:

Merged #19 https://github.com/Civcraft/RealisticBiomes/pull/19.

— Reply to this email directly or view it on GitHub <https://github.com/Civcraft/RealisticBiomes/pull/19#event-317780909 .

— Reply to this email directly or view it on GitHub <

https://github.com/Civcraft/RealisticBiomes/pull/19#issuecomment-107043292

.

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/RealisticBiomes/pull/19#issuecomment-107087111

.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/pull/19#issuecomment-107103534 .

ttk2 commented 9 years ago

putting the version with all todays Minor fixes into testing.

On Sat, May 30, 2015 at 7:56 PM erocs notifications@github.com wrote:

Specifically this one doesn't. Wait on other fixes before bothering to move it live.

On Sat, May 30, 2015 at 5:41 PM, ttk2 notifications@github.com wrote:

none of these fixes need testing?

On Sat, May 30, 2015 at 4:15 PM erocs notifications@github.com wrote:

It doesn't need testing. On May 30, 2015 6:57 AM, "ttk2" notifications@github.com wrote:

should this go on Civtest or do I want to wait for other minor fixes and do them all at once?

On Fri, May 29, 2015 at 11:24 PM erocs notifications@github.com wrote:

Merged #19 https://github.com/Civcraft/RealisticBiomes/pull/19.

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/RealisticBiomes/pull/19#event-317780909 .

— Reply to this email directly or view it on GitHub <

https://github.com/Civcraft/RealisticBiomes/pull/19#issuecomment-107043292

.

— Reply to this email directly or view it on GitHub <

https://github.com/Civcraft/RealisticBiomes/pull/19#issuecomment-107087111

.

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/RealisticBiomes/pull/19#issuecomment-107103534

.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/pull/19#issuecomment-107104539 .