search

Civcraft / RealisticBiomes

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/RealisticBiomes
7 stars 14 forks source link

Greenhouse effect problems #32

Closed Goldmattress closed 9 years ago

Goldmattress commented 9 years ago

Green house effect is heavily broken and it's relation to glow stone negating biome effects as well.

There are also problems with plants like cacti ignoring the need for sunlight.

I'll try and get some video and screenshot evidence of these things.

WildWeazel commented 9 years ago

Broken as in bugged or imbalanced? Has something changed recently?

ttk2 commented 9 years ago

Probably a little of both at this point.

On Tue, Jul 7, 2015, 10:48 AM Travis Christian notifications@github.com wrote:

Broken as in bugged or imbalanced? Has something changed recently?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/issues/32#issuecomment-119244940 .

Goldmattress commented 9 years ago

As far as I know if the spreadsheet is right it's been broken for a long, long time.

On Tue, Jul 7, 2015 at 4:49 PM, ttk2 notifications@github.com wrote:

Probably a little of both at this point.

On Tue, Jul 7, 2015, 10:48 AM Travis Christian notifications@github.com wrote:

Broken as in bugged or imbalanced? Has something changed recently?

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/RealisticBiomes/issues/32#issuecomment-119244940

.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/issues/32#issuecomment-119265588 .

WildWeazel commented 9 years ago

What exactly is wrong with glowstone? The documentation is kind of misleading. When it says "ignore biome" that means that the biome modifier is calculated independently of glowstone, so glowstone only acts as a light source. If that's false, then glowstone overrides the biome and provides a 75% modifier everywhere. There's been some confusion over that point before. We should probably refer to it as "light only" when true or "light and biome" when false.

ttk2 commented 9 years ago

We should probably clear this up by deciding how we want it to work and fixing it to work like that.

benjajaja commented 9 years ago

@Goldmattress I wrote up some general docs with something about greenhouse: https://github.com/Civcraft/RealisticBiomes/wiki#greenhouse

There are two problems with greenhouse, and when reporting bugs we should aim to distinguish them:

  1. Confusing namings and documentation and 2. incorrect/not-ideal behaviour.

IMO the greenhouse effect is way too high for most plants and defeats the purpose of RB.

ttk2 commented 9 years ago

how much do we have to nerf it then?

benjajaja commented 9 years ago

I would take it down to 25% (was 75%) and/or remove the "ignore biome" flag for almost all plants.

But there would probably be a very heavy opposition from anybody that has any farm in an unnatural biome.

WildWeazel commented 9 years ago

Removing "ignore biome" would result in a rate increase in almost all biomes

benjajaja commented 9 years ago

No it would decrease the rate but it wouldn't make sense anyway, only for underground farms. ignore that. Actually, "ignore biome" is always true when there is a greenhouse rate set!

It should be removed since it's not used - it only makes sense for underground farms already in a biome that allows growth.

ttk2 commented 9 years ago

just remove the setting and rebalance then. Just make RB less of a mess is the main goal.

benjajaja commented 9 years ago

I'm gonna leave this open for the removal of the unused "ignore biome" flag from code.

benjajaja commented 9 years ago

closed for new growth rate rewrite proposal