search

Civcraft / RealisticBiomes

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/RealisticBiomes
7 stars 14 forks source link

Cactus grows without sunlight #38

Closed Goldmattress closed 9 years ago

Goldmattress commented 9 years ago

Cactus grows without sunlight, even if there is a block above it, it will still grow.

benjajaja commented 9 years ago

That's vanilla. RB penalizes the lack of sunlight but it still grows.

Goldmattress commented 9 years ago

No its not look at the config, it inherits column which requires sunlight, this is a bug. On 16 Jul 2015 07:51, "Benjamin Grosse" notifications@github.com wrote:

That's vanilla. RB penalizes the lack of sunlight but it still grows.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/issues/38#issuecomment-121869540 .

benjajaja commented 9 years ago

"requires sunlight" means that a penalty is applied, not that it does not grow at all. Cactus also used to grow on civcraft before the update to persistence, just slower. I have a farm with the cacti in columns without direct sunlight, I have seen it work.

Goldmattress commented 9 years ago

That is absolutely not how it was supposed to work, every bit of documentation has indicated that all columnar plants require sunlight or glow stone to grow. I know very well that it has worked for a long time I just didn't bother to post about it till now.

benjajaja commented 9 years ago

See here how it was always a penalty. Before that commit I think there was a "openSkyBonus" modifier. So I don't know where you got that it absolutely requires full sunlight to grow.

Here is a screenshot of a vertical cactus farm that is over a year old: I remember that the builder did the math for not-full-sunlight and space efficiency.

ProgrammerDan commented 9 years ago

Given the long history, changing this would be an absolutely enormous nerf, perhaps two orders of magnitudes for a larger stacked farm.

I'm not in favor of this change, for now, instead we should fix the docs to reflect actual behavior. On Jul 17, 2015 8:08 PM, "Benjamin Grosse" notifications@github.com wrote:

See here https://github.com/Civcraft/RealisticBiomes/blame/master/src/com/untamedears/realisticbiomes/GrowthConfig.java#L298 how it was always a penalty. Before that commit I think there was a "openSkyBonus" modifier. So I don't know where you got that it absolutely requires full sunlight to grow.

Here is a screenshot of a vertical cactus farm that is over a year old:

https://camo.githubusercontent.com/d371d516e5ea3caa51a9d0936c94d13762b7f44f/687474703a2f2f692e696d6775722e636f6d2f7a7a644c57654e2e6a70673f31 I remember that the builder did the math for not-full-sunlight and space efficiency.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/issues/38#issuecomment-122458818 .

benjajaja commented 9 years ago

Ok closing, in the wiki article I wrote it is clear that lack of sunlight only applies a penalty https://github.com/Civcraft/RealisticBiomes/wiki#light-bonus