search

Civcraft / RealisticBiomes

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/RealisticBiomes
7 stars 14 forks source link

Making redwood grow in Ice plains and Ice mountains #50

Closed Maxopoly closed 9 years ago

Maxopoly commented 9 years ago

Someone asked for it and it kind of makes sense, so I thought why not.

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

benjajaja commented 9 years ago

I would leave cold_forest as it is, and add cold with 0.75 or similar. There are oak and spruce in vanilla ice biomes, but only a few scattered around, unlike taiga which is full of them.

Maxopoly commented 9 years ago

But "cold_forest" contains Taiga and Taiga Hills and so does "cold", which one would be used.

benjajaja commented 9 years ago

I would guess that taiga would apply from cold_forest which comes first: https://github.com/Maxopoly/RealisticBiomes/blob/master/src/com/untamedears/realisticbiomes/GrowthConfig.java#L217

Maxopoly commented 9 years ago

Wouldn't it be the one put into the biomeMultipliers hashmap second? The second put just overwrites what was in there before.

benjajaja commented 9 years ago

Yeah the order would have to be

cold: 0.75
cold_forest: 2.0

So that cold_forest only overwrite the values for tiaga in the map.

Maxopoly commented 9 years ago

Like this?

benjajaja commented 9 years ago

I'm 99% sure that would work, if you didn't make a test post for getRate rewrite we should merge this and test it all in one run.

benjajaja commented 9 years ago

Not that anybody will test it but it's an excuse if it fails later on the main.

Maxopoly commented 9 years ago

Yeah, I'll put it all in a post later