Civcraft / modmail_ticketmanager

Reddit mod mail manager that will port messages into a RequestTracker system
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Send modmails created by AutoModerator to the CivcraftMods queue #11

Closed ghost closed 9 years ago

ghost commented 9 years ago

Newbie posts keep getting stuck in purgatory and since we have a fanciful ticket system, they end up not getting looked at ever.

ttk2 commented 9 years ago

agreed

On Sun, Jun 28, 2015 at 2:11 PM Dr. Andrew Jawa notifications@github.com wrote:

Newbie posts keep getting stuck in purgatory and since we have a fanciful ticket system, they end up not getting looked at ever.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/modmail_ticketmanager/issues/11.

Pentom commented 9 years ago

Reviewed change request and there appears to be value here.

Change completed on the main modmail_ticketmanager repository (https://github.com/Pentom/modmail_ticketmanager). It appears that you all have forked the modmail code to include civcraft / minecraft specific data. Not adding this to the main repository as it does not fit with the overall theme for the script. If you wish these changes, just have a developer merge my changes down to the civcraft branch or cherrypick the following two checksums: 2397cd333310e28f2cec044a825cc97a1d520e1c d8e893f46fcf467ff700d480bfcba6f940afa831

Tested in my test suite and modmail bot usage myself. Works appropriately with no unintended consequences.

Implementation Details: New Configuration: requestTrackerOptionalAuthorToQueueMapping = [['automoderator',1],['different_user_goes_here',1]] # This example has automod posts going to queue 1. Can accept multiple author/queue tuples.

Things to remember: * You need to make sure the bot has all rights to the new queue. * You need to change the queue number for automoderator from 1 to whatever queue you wish to use for it. * You need to decide if people who can access this queue should be able to access the custom field for replying. If so, you will need to edit the custom field to change the 'Applies To' section to include this new queue.

erocs commented 9 years ago

Not adding this to the main repository as it does not fit with the overall theme for the script

That's fine as I don't think that patch should be in our master for trading with you.

On Sat, Jul 4, 2015 at 10:47 AM, Pentom notifications@github.com wrote:

Reviewed change request and there appears to be value here.

Change completed on the main modmail_ticketmanager repository ( https://github.com/Pentom/modmail_ticketmanager). It appears that you all have forked the modmail code to include civcraft / minecraft specific data. Not adding this to the main repository as it does not fit with the overall theme for the script. If you wish these changes, just have a developer merge my changes down to the civcraft branch or cherrypick the following two checksums: 2397cd3 https://github.com/Civcraft/modmail_ticketmanager/commit/2397cd333310e28f2cec044a825cc97a1d520e1c d8e893f https://github.com/Civcraft/modmail_ticketmanager/commit/d8e893f46fcf467ff700d480bfcba6f940afa831

Tested in my test suite and modmail bot usage myself. Works appropriately with no unintended consequences.

Implementation Details: New Configuration: requestTrackerOptionalAuthorToQueueMapping = [['automoderator',1],['different_user_goes_here',1]] # This example has automod posts going to queue 1. Can accept multiple author/queue tuples.

Things to remember:

  • You need to make sure the bot has all rights to the new queue.
  • You need to change the queue number for automoderator from 1 to whatever queue you wish to use for it.
  • You need to decide if people who can access this queue should be able to access the custom field for replying. If so, you will need to edit the custom field to change the 'Applies To' section to include this new queue.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/modmail_ticketmanager/issues/11#issuecomment-118537103 .

Pentom commented 9 years ago

To the best of my knowledge, there is nothing more needed to satisfy this issue except merge in the changes mentioned above. As such, will stop monitoring this particular issue and leave it to you all to adjust as needed.

Get my attention if you have any questions.

Thanks!

erocs commented 9 years ago

No worries, just split civcraft specific changes into the civcraft branch. Thanks!