search

CiviCooP / org.civicoop.pdfapi

Create PDF files and send them to a specified e-mail address from the API
Other
0 stars 11 forks source link

Not compatible with CiviCRM < 4.5 #1

Closed sluc23 closed 9 years ago

sluc23 commented 9 years ago

I don't know if intended to be compatible with CiviCRM < 4.5 (as far as it says in the info.xml it should be), but these previous versions doesn't have the class _CRM_Core_DAOMessageTemplates

Error: require_once(): Failed opening required 'CRM/Core/DAO/MessageTemplates.php'

jaapjansma commented 9 years ago

Thanks. For reporting. It should be compatible with civicrm 4.3.x and it is working on 4.3.

sluc23 commented 9 years ago

I forked the repo to make it compatible with CiviCRM 4.4, and added extra features (multiple contact_id's, pdf_format as parameter, etc) Then if you agree I can make a PR to add those to your repo

sluc23 commented 9 years ago

https://github.com/ixiam/org.civicoop.pdfapi

jaapjansma commented 9 years ago

Yes please create a PR! Thanks for your work.

jaapjansma commented 9 years ago

I have checked your fork. Could you also update the documentation? For multiple contact_ids? And have you tested it with just creating a pdf for a single contact?

sluc23 commented 9 years ago

I will update the docs, and I'm still testing it :)

jaapjansma commented 9 years ago

Thanks a lot for your work! I have also updated the org.civicoop.emailapi and org.civicoop.smsapi becasue they are basicly all the same