don't create a second CiviRuleAction on reinstall

CiviCooP / org.civicoop.pdfapi

Create PDF files and send them to a specified e-mail address from the API

Other

0 stars 11 forks source link

don't create a second CiviRuleAction on reinstall #17

Closed MegaphoneJon closed 4 years ago

MegaphoneJon commented 5 years ago

The current approach to adding the CiviRuleAction handles installation of a new entry but not its removal. I assume this is intentional. However, we should ensure that if we uninstall and reinstall we don't create a second (etc.) CiviRuleAction.

MegaphoneJon commented 5 years ago

Seeing PDF API 2.3 prompted me to revisit these PRs. I realize that this actually contains two fixes, and I don't adequately explain the second fix.

In various parts of the upgrade code, PDF API checks if CiviRules is installed. However, because Extension.get only returns the first 25 extensions by default, this can fail on sites with > 25 extensions. I fixed that as part of the original bugfix (above) but also fixed it in ther rest of the codebase.

agileware-justin commented 4 years ago

@MegaphoneJon @ErikHommel PR can be closed, it's been resolved by https://github.com/CiviCooP/org.civicoop.pdfapi/pull/23