Closed MegaphoneJon closed 4 years ago
Seeing PDF API 2.3 prompted me to revisit these PRs. I realize that this actually contains two fixes, and I don't adequately explain the second fix.
In various parts of the upgrade code, PDF API checks if CiviRules is installed. However, because Extension.get
only returns the first 25 extensions by default, this can fail on sites with > 25 extensions. I fixed that as part of the original bugfix (above) but also fixed it in ther rest of the codebase.
@MegaphoneJon @ErikHommel PR can be closed, it's been resolved by https://github.com/CiviCooP/org.civicoop.pdfapi/pull/23
The current approach to adding the CiviRuleAction handles installation of a new entry but not its removal. I assume this is intentional. However, we should ensure that if we uninstall and reinstall we don't create a second (etc.) CiviRuleAction.