CiviMRF / cmrf_core

Drupal Core for CMRF
GNU Affero General Public License v3.0
2 stars 6 forks source link

[Views integration] How is caching supposed to work? #48

Open jensschuppe opened 3 years ago

jensschuppe commented 3 years ago

https://github.com/CiviMRF/cmrf_core/blob/e3e3c9dfc4e4bb78c97580fd26abd22233df1db9/cmrf_views/src/Plugin/views/query/API.php#L225

This seems to have been ported from 7.x, but I could neither get it to work nor do I understand where this caching option should be coming from.

Can anyone involved shed some light on whether Views caching (at least time-based) in the View's configuration is supposed to work with caching CiviMRF calls at all?

@fabioneves @jaapjansma @kainuk

jaapjansma commented 3 years ago

In Drupal 7 you can set a caching timeout in the views ui. This is per view. This caching setting is then passed on to civi mc restface calls.

jensschuppe commented 3 years ago

Thanks, @jaapjansma, so this will need to be adapted for D8 since caching configuration in D8 is per Views display and can only be used if time-based caching is enabled, if I got that correctly.

Has anyone taken on that for D8 yet?

jaapjansma commented 3 years ago

Yes indeed this need to be adapted to d8. I also believe that the caching setting in d7 is per display of a view.

jensschuppe commented 1 year ago

Linking #62