Closed jensschuppe closed 1 year ago
@kainuk, @jaapjansma, @dontub - this would be happy to receive your review or test feedback!
The code in https://github.com/CiviMRF/cmrf_core/blob/dc975770bf36b7a9a609d1211da9b6aa68f42e29/cmrf_views/src/CMRFViews.php#L304
is only relevant for APIv3 and the index in the first check should be type
as well and probably isset
instead of empty
.
https://github.com/CiviMRF/cmrf_core/blob/dc975770bf36b7a9a609d1211da9b6aa68f42e29/cmrf_views/src/CMRFViews.php#L315 The type check is only relevant for APIv3.
Pending:
I'm not sure whether File
fields contain their URLs only with APIv4 or that changed for APIv3 as well (the File field handler in CiviMRF Views expects a CiviCRM Attachment entity ID instead), but downloading the file and displaying it with this handler might not work because of permission restrictions in CiviCRM, at least for some file fields. So this isn't fully working.
This will be available with a 2.1.x
version of the module.
With CiviMRF/CMRF_Abstract_Core#18, this introduces support for CiviCRM APIv4 and partly resolves #57 (leaving out the Webform integration for now).
This will be backwards-compatible so that it can be released within the
2.x
major version branch.entity
andaction
columns to thecivicrm_api_call
table (via the adapted schema provided by CiviMRF/CMRF_Abstract_Core) via ahook_update_N()
implementationCMRFDataset
configuration entity with anapi_version
property, which is configurable per CiviMRF Views Datasetgetfields
calls for the new structure those calls return with APIv4 in theCMRFViews
controllerAPI4
(civicrm_api4
) Views query plugin for APIv4 DatasetsCMRFProfile
configuration entity with anurlV4
property, which is configurable per CiviMRF ProfileCall
implementation