search

CiviMRF / cmrf_core

Drupal Core for CMRF
GNU Affero General Public License v3.0
2 stars 6 forks source link

[views] Close all open output buffers on file download #64

Closed dontub closed 1 year ago

dontub commented 1 year ago

If there is any output buffer open, nothing apart from the headers is sent to the client. This happens for example if a view is embedded as block in another page.

jensschuppe commented 1 year ago

@jaapjansma, @kainuk any chance you'll be able to have a look at this? I'd like some confirmation this doesn't introduce side effects and you seem to have some real-world use-cases of file downloads, don't you?

@dontub will go ahead merging this anyway, but another pair of eyes is always better :smile:.

kainuk commented 1 year ago

Hi @jensschuppe, I did not answer because I was on leave. Your change seems reasonable. I I encounter any issues in using it I let you know.