CiviWiki / OpenCiviWiki

Building a Better Democracy for the Internet Age
https://civi.wiki
Other
587 stars 346 forks source link

Move Notificatio's code to Django instead of JS #1490

Open JonanOribe opened 1 year ago

JonanOribe commented 1 year ago

Idea summary

Looking at project\core\templates\static\js\notifications.js, I saw that the logic behind notification's component is running over JS. Maybe will be better to move this to Django/Python syntax to unify the platform.

Further details

Will be easier to rewrite this code as DJANGO {% if %} {% else%}, that use JS on one side of the project and Python on another

image

I could take this task if necessary

JonanOribe commented 1 year ago

@brylie looking at the admin panel, I found that we have two diferent types of notifications. Could be interesting change the name of one of them to avoid misunderstandings

image

One is like a notification like "something happens" (new follower) and the other one is a notification on detail. What you think about this?

brylie commented 1 year ago

Yeah, we should clarify the difference between those notifications. Can you find the places in the code where both types of notifications are defined?

Lvcky-gg commented 1 year ago

I can take this