CivicActions / accessibility

CivicActions Accessibility Site: A collection of resources about digital accessibility and how it aligns with open source, CivicTech and Digital Transformation.
https://accessibility.civicactions.com
Other
27 stars 11 forks source link

Switch deploy from automatic github pages to deploy that is done with custom github action #635

Open dmundra opened 2 years ago

dmundra commented 2 years ago

The automatic github pages deploy intermittently fails e.g. https://github.com/CivicActions/accessibility/runs/6712655812?check_suite_focus=true. Tracking down the error I found that this is likely caused by the Jekyll version (3.9.2) and sass race conditions (see https://github.com/18F/federalist-uswds-jekyll/issues/223). Looks like the default github pages deploy is locked into that version (see https://github.com/github/pages-gem/issues/651#issuecomment-581069671). So recommendation is to do own GitHub actions deploy where we build the site with Jekyll version 4 (like we do the QA site) and deploy it to a branch 'gh-pages' and then use that branch to render the site.