Closed adriancooke closed 7 months ago
Thanks @adriancooke. Our pre-commit tools hates 'right apostrophe ’
' so it is going to put back the other one automatically.
You can test changes in this branch at https://accessibility-qa.civicactions.com/. If you pushed additional changes and need to reapply them, remove and readd the label 'qa-pull-request'. The QA repo can be accessed at https://github.com/CivicActions/accessibility-qa.
Thanks @adriancooke. Our pre-commit tools hates 'right apostrophe
’
' so it is going to put back the other one automatically.
😱 Oh, okay. Thanks for explaining, @dmundra! I see it deployed to the QA site correctly. I’m still seeing Review required and Merging blocked errors. I also tagged Mike to review. Assume I should wait now, but please let me know if I have to resubmit anything.
Thanks @adriancooke. Our pre-commit tools hates 'right apostrophe
’
' so it is going to put back the other one automatically.😱 Oh, okay. Thanks for explaining, @dmundra! I see it deployed to the QA site correctly. I’m still seeing Review required and Merging blocked errors. I also tagged Mike to review. Assume I should wait now, but please let me know if I have to resubmit anything.
Ya no need to resubmit the rest of the changes look good. I will let @mgifford review the content and approve. Once he does that you can merge it. You can also enable 'auto-merge' which will do the merge after he approves it without you needing to hit the button.
@mgifford are you able to review my PR?
Using this as practice. Updated some formatting characters to improve readability (swapped hyphen - for em dash —, prime ' for right apostrophe ’, etc.). Also updated the Australian Government Design System link to point to the Archive.org version because they discontinued it in 2021.