search

CivicActions / compliance-io

Python library for reading/writing compliance as code
GNU General Public License v3.0
10 stars 5 forks source link

Oscal 1 0.0 #26

Closed openprivacy closed 3 years ago

openprivacy commented 3 years ago

This seems to work

openprivacy commented 3 years ago

Easy (non-conclusive) test for multiple components:

cd ..
git clone git@github.com:CivicActions/ssp-toolkit.git
cd compliance-io
poetry run python examples/oc_to_oscal_components.py ../civicactions/ssp-toolkit/opencontrol/opencontrol.yaml
woodt commented 3 years ago

So this looks pretty good, I think :-) There were a bunch of formatting and lint errors that I fixed and pushed. You should install pre-commit! I did NOT get a chance to fix the mypy errors, though, so this PR still needs some work. In order for me to commit/push my fixes, I disabled the mypy hook in .pre-commit-config.yml. You should uncomment that hook to reenable it, and then run pre-commit run --all.

openprivacy commented 3 years ago

Pushed updates that get test_oscal_ssp to produce valid code.

openprivacy commented 3 years ago

Thanks to the awesome pre-commit hooks the code is cleaner and more correct now - ready for your consideration.