CivicActions / openacr-editor

With this tool, people can generate Accessibility Conformance Report in the OpenACR format.
https://civicactions.github.io/openacr-editor/
Other
1 stars 0 forks source link

Math confusion in the report, redo layout #23

Open mgifford opened 1 year ago

mgifford commented 1 year ago

Daniel, I'm hoping you can look into this.

As you can see here https://github.com/CivicActions/openacr/blob/295e763d145cbad72fb89e6085aed5a4c37822b4/openacr/drupal-10-16.html#L335C18-L335C18

The math doesn't add up:

Conformance to the 30 criteria listed below is distributed as follows: • 32 supported • 20 partially supported • 0 not supported • 68 not applicable

I'm not exactly sure why, but is something that should be resolved.

dmundra commented 1 year ago

@mgifford I am not sure why the math is not adding up. I check it manually and also used yq to do the math with the yaml file and I am getting the same numbers as the table.

dmundra commented 1 year ago

Ah, the math is not wrong but the display is confusing. From @maggiewachs, the total is actually 30x4 (4 types of levels for each criteria). Solution is to instead display the numbers as table with rows being the level and columns the different types (Web, Electronic Documents, Software, Authoring Tool).

Potential table display: Screenshot of table from PDF