search

CivicCode / uReport-client

A redesigned front-end for Bloomington's citizen reporting application
MIT License
1 stars 1 forks source link

Clean-Up for Challenge Submission #7

Closed mattbatman closed 6 years ago

mattbatman commented 6 years ago
matt-a-t commented 6 years ago

I would say let's leave the CSS/HTML markup for the site for now. We can explain somewhere (the readme?) that eventually the form itself will be inserted into the div via Javascript once it's ready to deploy.

matt-a-t commented 6 years ago

I just say that so they can get a clear idea of what we are thinking. Would we be interested in deploying this to Netlify or something like that to have a public url available for them to look at without having to download/run the project?

mattbatman commented 6 years ago

I just say that so they can get a clear idea of what we are thinking. Would we be interested in deploying this to Netlify or something like that to have a public url available for them to look at without having to download/run the project?

On this repo, we have no server-side code, so we could also just use GitHub pages. We'd probably want to make a different branch that holds the build, if we went that route.

mattbatman commented 6 years ago

How do we want to handle drafting an email to submit tonight? Who wants to be responsible for hitting send?

matt-a-t commented 6 years ago

I can write the email after I finish the POST request tonight. Does anyone else have anything they would like to commit or am I good to send it off as soon as I am finished? I can let everyone know when I'm done if anybody wants to double check things before the final submission.

mattbatman commented 6 years ago

I have nothing else to commit. Personally, I'd be comfortable with you sending off a submission at your discretion.

dpalazz commented 6 years ago

Go for it. Let us know if you need any help with the Post.

Thanks!

On Tue, Apr 17, 2018 at 4:51 PM Matt Batman notifications@github.com wrote:

I have nothing else to commit. Personally, I'd be comfortable with you sending off a submission at your discretion.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CivicCode/uReport-client/issues/7#issuecomment-382141058, or mute the thread https://github.com/notifications/unsubscribe-auth/ANAHSmFrkPGBujIs7mw5xATp0s0SgPJeks5tplW2gaJpZM4TTYEM .

mattbatman commented 6 years ago

@matt-a-t How are things coming?

matt-a-t commented 6 years ago

The post query is proving really difficult. I'm getting this error:

GraphQLError: Syntax Error: Expected Name, found :

I think I have to declare the params i'm using for the query

mattbatman commented 6 years ago

I've started to try to set this up, too. Are you using the Mutation component?

matt-a-t commented 6 years ago

I'm not right now, but I think that maybe I should be

mattbatman commented 6 years ago

I found these in reference to your error. I think you're on the right track: stack overflow

mattbatman commented 6 years ago

Do you already have an email drafted? At this point, it may be best to call it.

matt-a-t commented 6 years ago

I was about to say the same thing. I'm going to keep working on it for a bit I think, I bet if I stop working without the time pressure I can figure it out.

I'll write the email now.

mattbatman commented 6 years ago

Thanks for all your work. I got the email. I'm going to bed. I'm sure you'll get it working 5 minutes from now.