search

CivicStack / civicstack

A repository for open source civic tools from many countries and organizations
Other
37 stars 6 forks source link

Remove color field on apps #37

Closed mjlescano closed 7 years ago

mjlescano commented 8 years ago

This Color Picker: image

We only ask for it to put a background on the image. Instead, the image should be background-size: cover;

jfresco commented 8 years ago

I think I'm not getting it. It is a fact that we are using the backgroundColor property to put it as a background color for the logo. But if we remove it, the logo background will be white, and I don't get how putting the logo as background-size: cover; will improve it.

For example, if we apply that styles to this: image

it will become this: image

Can you send me some mockups in order to get what is the visual improvement you want to achieve?

mjlescano commented 8 years ago

What about using background-size: contain + corner-colors for background-color ?

mjlescano commented 8 years ago

or simply background-size: contain + background-color: #333

mjlescano commented 8 years ago

buuuut, what about when is a .png with transparent background? :/

jfresco commented 8 years ago

Don't know. Please send me some mockups or example (perhaps editing the DOM directly from DevTools with the changes you want) so I can understand what you want to achieve.

mjlescano commented 7 years ago

We're closing this until there's a better solution