Don't deploy storybook when checks for success fail

[patcon]

Re: https://github.com/bitovi/github-actions-storybook-to-github-pages

We need to run deploy after the checks for success. Just realized in the CI run that it was deploying the the action step, and so a failure didn't matter. We want deploy in a separate step, so it doesn't happen https://github.com/CivicTechTO/polis-storybook/actions/runs/11469336432/job/31916377978

To Do

• [ ] move deploy step after the step where checking for PR build success (so deploy doesn't happen before the check)
• [ ] run check for main storybook building (currently only attempting to check PR builds)

[patcon]

Also, we should have a way to check for failures in the main build. This should be rare if we use PRs, but ca n happen if we push direct to main. Maybe this is a separate ticket tho

[thomassth]

Rule added

[patcon]

Thanks for chipping in with issue queue gardening, but this isn't yet started. Added specific todos to make that clear 🙏