CivicTechTO / tRacket-dashboard

Noise monitoring dashboard built for the tRacket initiative.
https://tracket.info/
MIT License
7 stars 6 forks source link

Fix navbar width & logo placement #17

Closed danieltsoukup closed 2 months ago

danieltsoukup commented 3 months ago

Describe the bug The nav bar is not consistent with the main https://tracket.info/ website, does not extend to the very end of the page and the logo is awkwardly placed.

To Reproduce Visit the dashboard on any location page, e.g.: https://dashboard.tracket.info/locations/756264 and compare with https://tracket.info/

Expected behavior In this ticket, we are aiming to fix the following

image

Relevant Code

harshiltomar commented 3 months ago

@danieltsoukup Can I work on this issue ? Kindly assign it to me

danieltsoukup commented 3 months ago

Welcome to the project, @harshiltomar ! Thank you for offering to help, happy to assign you the issue. Let me know if you have any questions as you start exploring the code. I added some extra details to the ticket, the long term goal is to have more consistency between the https://tracket.info/ website and the dashboard.

harshiltomar commented 3 months ago

Hey ! on running the docker image locally after make prod_build and make prod_container.It seems to be exisiting itself within a second.

on docker logs noise-dashboard, I get : [2024-08-10 08:25:27 +0000] [7] [INFO] Starting gunicorn 21.2.0 [2024-08-10 08:25:27 +0000] [7] [INFO] Listening at: http://0.0.0.0:8501 (7) [2024-08-10 08:25:27 +0000] [7] [INFO] Using worker: sync [2024-08-10 08:25:27 +0000] [8] [INFO] Booting worker with pid: 8 [2024-08-10 08:25:27 +0000] [8] [ERROR] Exception in worker process Traceback (most recent call last): File "/usr/local/lib/python3.11/site-packages/gunicorn/arbiter.py", line 609, in spawn_worker worker.init_process() File "/usr/local/lib/python3.11/site-packages/gunicorn/workers/base.py", line 134, in init_process self.load_wsgi() File "/usr/local/lib/python3.11/site-packages/gunicorn/workers/base.py", line 146, in load_wsgi self.wsgi = self.app.wsgi() ^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/gunicorn/app/base.py", line 67, in wsgi self.callable = self.load() ^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/gunicorn/app/wsgiapp.py", line 58, in load return self.load_wsgiapp() ^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/gunicorn/app/wsgiapp.py", line 48, in load_wsgiapp return util.import_app(self.app_uri) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/gunicorn/util.py", line 371, in import_app mod = importlib.import_module(module) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "<frozen importlib._bootstrap>", line 1204, in _gcd_import File "<frozen importlib._bootstrap>", line 1176, in _find_and_load File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 690, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 940, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "/usr/src/project/app/app.py", line 22, in <module> Logging.setup()

danieltsoukup commented 3 months ago

Hey, it looks like the fail happened at the Logging.setup() call? The line will try to create a new log file and write to it so you can try to double-check that the container would have permissions to do that if you are not running with sudo. Are you running it on Mac/Win/Linux?

harshiltomar commented 3 months ago

Previsouly ran it from Macos from vs-terminal / mac terminal . Will check for the permissions

danieltsoukup commented 3 months ago

You can also try to create an app/logs/main.log file manually, see then if the container runs properly.

danieltsoukup commented 3 months ago

Hey, @harshiltomar did you manage to resolve the issue?

danieltsoukup commented 2 months ago

Navbar width has been fixed, leaving the logo placement as is for the moment and closing this item. @harshiltomar thanks for the interest, let me know if you're up to working on something else.