search

CivicTechTO / ttc_subway_times

A scraper to grab and publish TTC subway arrival times.
GNU General Public License v3.0
40 stars 30 forks source link

start collecting coverage #49

Closed perobertson closed 5 years ago

perobertson commented 5 years ago

Its often handy to see what code was executed during tests. This adds that that and is displayed in an html report available as a build artifact.

The main issue I ran into when adding this was that the source code was stored directly in the root directory. Unfortunately coverage could not be collected from there. The fix is to use the recommended project setup as suggested by tox.

This moves ttc_api_scraper.py → src/ttc_api_scraper/__init__.py.

When this deploys, any cron will need to be updated to specify the new path.

radumas commented 5 years ago

The rename of ttc_api_scraper.py → src/ttc_api_scraper/__init__.py is going to conflict with #50, which splits the writing to [PostgreSQL, S3] into a separate file.

I think it's also fine if __init__.py is an empty file and we keep ttc_api_scraper.py the way it's named.

radumas commented 5 years ago

Close by #53