search

CivicTechWR / WRvotes

https://waterlooregionvotes.org
MIT License
4 stars 12 forks source link

New link for Jen Vasic/active transit meetup #70

Closed hjroaf closed 6 years ago

hjroaf commented 6 years ago

It's still doing this thing of thinking many lines have changed, but in reality have only changed the one field.

pnijjar commented 6 years ago

No, this is more serious. Your update changed many of the date formats from YYYY-MM-dd to dd/MM/YYYY format (eg 2018-08-01 to 01/08/2018). That is no good and will break things. This may be a setting in your spreadsheet program.

Also I feel that the old link (although ugly) is probably better than the new one because it is more accessible to people not on Facebook. If you really want the Facebook link instead then I will merge it, but you have to fix the format of the file first.

pnijjar commented 6 years ago

I don't know whether it is better to close this pull request and have you submit a different one or to leave this open. I will leave it open for now and hope nobody commits it.

hjroaf commented 6 years ago

Oh no! Ok, just let me know if there's anything I can do. Will make sure to check the date format for strangeness in future updates.

On Mon, Aug 27, 2018, 14:52 Paul Nijjar notifications@github.com wrote:

I don't know whether it is better to close this pull request and have you submit a different one or to leave this open. I will leave it open for now and hope nobody commits it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CivicTechWR/WRvotes/pull/70#issuecomment-416329537, or mute the thread https://github.com/notifications/unsubscribe-auth/AoY9HC4kWS99Ciy0LOdlnOF85XQDWupxks5uVD_jgaJpZM4WN1qv .

pnijjar commented 6 years ago

In Numbers, it looks like you can change cell formatting on a sheet-by-sheet basis, but not globally unless you change your system settings on the Mac (!):

Sheet by sheet: https://support.apple.com/kb/PH17075?locale=en_US&viewlocale=en_US (So select the columns for beginning and end date, and then disable the date formatting)

Overall: https://apple.stackexchange.com/questions/75855/how-to-set-default-number-formatting-in-numbers (which is probably not something you want to do)

hjroaf commented 6 years ago

I actually made the change/submitted the pull request from my work machine which is Windows, so my Excel settings were the issue. If you feel the blog link is best, just go ahead and close this request. In future I'll just use my mac because that didn't cause as many issues and I don't want to spend time mucking around in Excel.

On Mon, Aug 27, 2018 at 7:40 PM Paul Nijjar notifications@github.com wrote:

In Numbers, it looks like you can change cell formatting on a sheet-by-sheet basis, but not globally unless you change your system settings on the Mac (!):

Sheet by sheet: https://support.apple.com/kb/PH17075?locale=en_US&viewlocale=en_US (So select the columns for beginning and end date, and then disable the date formatting)

Overall: https://apple.stackexchange.com/questions/75855/how-to-set-default-number-formatting-in-numbers (which is probably not something you want to do)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CivicTechWR/WRvotes/pull/70#issuecomment-416403412, or mute the thread https://github.com/notifications/unsubscribe-auth/AoY9HIhHk2t1OKCi3ouYCH3E0XbQb3RQks5uVIOFgaJpZM4WN1qv .

hjroaf commented 6 years ago

Added another event, but looks like it got added to this open pull request...

pnijjar commented 6 years ago

Grr.

Okay. I took the event you added and manually stuck it in the spreadsheet, then committed it.

From your end, I think you need to go to the Branches menu and delete the branch that is the pull request. Then you should be able to make new pull requests that won't pull in the bad stuff. I am going to close this pull request, but I don't think your desktop client will get the hint.

I think this process will get smoother as we get more used to it. Hang in there!