Civitasv / cmake-tools.nvim

CMake integration in Neovim
GNU General Public License v3.0
353 stars 56 forks source link

if executor is terminal, then no double quotes around path to build folder #205

Open Arniiiii opened 5 months ago

Arniiiii commented 5 months ago

Bug description

if executor is terminal, then no double quotes around path to build folder

Steps to reproduce

  1. Set in config `cmake_executor -> name = "terminal"
  2. image

Minimal configuration

Expected behavior

path with double or ordinary quotes. ( "/path/to/build foler " or ' /path/to/build folder' )

Screenshots

Environment

Contents in the *cmake-tools* buffer

Civitasv commented 4 months ago

Use the latest commit, I've fixed it.

Arniiiii commented 4 months ago

It's kinda strange now: with terminal executor it works now

But with quickfix it does really strange stuff and idk why since in raw console the command that goes to quickfix seems to be good: image

I can confirm it happens if kit name has spaces.

Arniiiii commented 3 months ago

Oh, it seems similar symptoms happens if just path to project folder contains spaces even when kit name doesn't have spaces.