CiwPython / Ciw

Ciw is a simulation library for open queueing networks.
http://ciw.readthedocs.io
MIT License
148 stars 42 forks source link

Update tracker parameter in simulation.py #219

Closed galenseilis closed 10 months ago

galenseilis commented 11 months ago

Default argument was a mutable type. Generally the advice I've read is to only use immutable types as defaults. Although I was not running into this issue, it can in principle lead to unusual behavior when a default argument is mutable.

In this case I have changed the default argument of tracker to None, but when this happens the same tracker will be assigned as before.

geraintpalmer commented 10 months ago

Thank you, I didn't know about this. Sounds like a good change :+1: