Ckathode / archimedes-ships

Archimedes' Ships Minecraft mod
MIT License
49 stars 53 forks source link

Aweseome work! #21

Open PumaBlack opened 9 years ago

PumaBlack commented 9 years ago

Dear darkevilmac:

At first, THANK YOU for updating and making the AS Mod better than before.

I freaked out, seeing that logistic pipes are working now on my ship. I have to be patient for a minute, but then: whohaa! all connections go green, they work fine.

Than the rotation, almost every block from other mods remember there alignment after the unmonut of my ship. The drawbridge from tinkers construct fails, but hey - this will maybe get fixed ;)

Even Thermal Expansion Pipes work almost(!) fine, a few connection bugs between chests and pipes i'd figured out. Awesome!

Project Red is not possible at all (Gates and wires). But hey - again: THANK YOU for taken time to push this great mod forward.

THUMBS UP!

TehStoneMan commented 9 years ago

I don't think this should be considered as a pull request, as it appears to be replacing the entire original Archimedes' Ships with Darkevilmac's Plus version. Also, this doesn't seem to come from the code author. Maybe you just meant to leave a comment?

darkevilmac commented 8 years ago

I think he did, I ask that this is closed unless you want a complete re-license :P

Feels pretty cool looking at all those commits I've made though. And that's not even including the MovingWorld changes.

Not to sound rude but I'm not really sure why people are still making PRs to the original mod, I'm starving for developers on my end ;-;

arcriley commented 8 years ago

Not to sound rude but I'm not really sure why people are still making PRs to the original mod, I'm starving for developers on my end ;-;

@darkevilmac Many people continue to use the original Archimedes Ships since its available under the MIT license and thus does not require permission to redistribute or fork.

If you want more people to contribute to your fork then release it under a FOSS license. Your choice in licensing is driving away both users and potential contributors.