Ckathode / archimedes-ships

Archimedes' Ships Minecraft mod
MIT License
49 stars 53 forks source link

Removed hack for tile entities, added proper fix #3

Closed Pyro93735 closed 9 years ago

Pyro93735 commented 10 years ago

Admittedly, rebuilding the tile entity from NBT data on ship disassemble was at best a messy solution. Some mods such as Applied Energistics do not allow editing their tile entities's NBT data outside of the methods implemented through their API, leading to errors/crashes on ship disassemble. Following advice from Algorithm2X, tile entities are now invalidated, moved, and re-validated instead, which address the problems with tile entities more thoroughly than my previously committed hack.

Some code was deleted from MobileChunks as in my testing it was found to either not be used, to be redundant or to cause mischief with the tile entities.