search

Ckathode / archimedes-ships

Archimedes' Ships Minecraft mod
MIT License
49 stars 53 forks source link

Compatibility bug / rendering bug with Carpenters Blocks #8

Open Nuchaz opened 9 years ago

Nuchaz commented 9 years ago

There is a rendering issue with the Carpenters Blocks garage door and the ships mod that I ran across today. If you have a garage door that is 2 or more blocks tall on a ship, and that garage door is open when you mount the ship, terrible terrible things happen. The console will start spitting GL ERROR and the game screen will start flashing and become graphicly unresponsive. I presume the issue is when the ships mod tries to render the invisible blocks from the open garage door.

I found this while implementing the getValidRotations and rotateBlock methods into all the relevant carpenters blocks. I've been playing a lot of SMP with ships mod and carpenters block both installed and really wanted to use slopes on my ships, so I figured I would help him out.

Ckathode commented 9 years ago

Carpenters Block and Archimedes' Ships have never been worked well together. I have tried my best to make the block renderer (which mainly consists of a call to the Minecraft block renderer, so I do not understand where all these problems come from...) as safe as possible, but Carpenters Block keeps getting around it in some way. Now it is even a GL error. I will look into CB's source to find something.

Nuchaz commented 9 years ago

Thanks for having a look. I haven't noticed any other issues with rendering and CB, so perhaps some of the recent updates for CB resolved some previous issues.