Ckbhatia / Ck-gatsby-blog

A beautiful and featureful gatsby blog starter for bloggers. It is an open-source project.
https://chetanblog.netlify.com
MIT License
37 stars 33 forks source link

Added PrismJS, but it won't work with Contentful Rich Text #10

Closed mihirgupta0900 closed 3 years ago

mihirgupta0900 commented 3 years ago

I have successfully added PrismJS to the website. But there is an issue, contentful rich test editor does not specify the language of the code as mentioned here. You can resolve this by using the mardown editor from contentful. Nevertheless, I haven't made any changes apart from adding prismjs.

netlify[bot] commented 3 years ago

Deploy request for chetanblog pending review.

Review with commit 60585fd6628a704a8e3721875e65120da549c11d

https://app.netlify.com/sites/chetanblog/deploys

Ckbhatia commented 3 years ago

Hi @mihirgupta0900, Can you please create another branch from master and apply these changes in that branch?

It will be helpful to test your code.

mihirgupta0900 commented 3 years ago

Sure, let me make the changes.

mihirgupta0900 commented 3 years ago

Hey, I had a doubt, branch in your main repository or the forked one? I don't have push access to your repo. You can pull the code from the forked repo and check changes there. Or if there are better methods, please let me know.

Ckbhatia commented 3 years ago

Hi,

You can do this on your fork. I will download your fork and run it.

Thanks

On Sat, 3 Oct, 2020, 2:36 pm Mihir Gupta, notifications@github.com wrote:

Hey, I had a doubt, branch in your main repository or the forked one? I don't have push access to your repo. You can pull the code from the forked repo and check changes there. Or if there are better methods, please let me know.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Ckbhatia/Ck-gatsby-blog/pull/10#issuecomment-703072869, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2SGUNF4MZOUMMEVMB2FTLSI3SQDANCNFSM4SCQN3SA .

mihirgupta0900 commented 3 years ago

My updates are on the master branch of my fork, please check it.

Ckbhatia commented 3 years ago

I will review soon

On Sat, 3 Oct, 2020, 3:01 pm Mihir Gupta, notifications@github.com wrote:

My updates are on the master branch of my fork, please check it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Ckbhatia/Ck-gatsby-blog/pull/10#issuecomment-703075831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2SGUJVLMNJEKSJJBQLDKDSI3VOBANCNFSM4SCQN3SA .

Ckbhatia commented 3 years ago

Your PR is in review now. I will update you soon.

Ckbhatia commented 3 years ago

Hi @mihirgupta0900, I have reviewed your commits. It is working fine for me.

Can you please run this git command and push changes: git pull --rebase <this project> feature

You need to pull, merge/rebase and push the latest changes from the feature branch. So, I can merge your master branch.

P.S.: Your one star would help us.

mihirgupta0900 commented 3 years ago

Done!