Ckbhatia / Ck-gatsby-blog

A beautiful and featureful gatsby blog starter for bloggers. It is an open-source project.

https://chetanblog.netlify.com

MIT License

37 stars 33 forks source link

Closed marcotgs closed 3 years ago

marcotgs commented 3 years ago

11

netlify[bot] commented 3 years ago

Deploy request for chetanblog accepted.

Accepted with commit 215249d66ff1139aba8c9a59db815effeced05b1

Ckbhatia commented 3 years ago

There's window property error as it isn't available in build time.

Can you fix this error and deploy it for review?

marcotgs commented 3 years ago

It's fixed, but I don't know how I can deploy this new commit.

Ckbhatia commented 3 years ago

I have deployed your PR and review it. Your work must be appreciated.

There are some changes needed for UI as it it looking broken.

Can you improve that?

marcotgs commented 3 years ago

Do you mean looking broken on mobile?

Could you give some examples about what could be improved?

Ckbhatia commented 3 years ago

Okay, I will give you mockup.

Ckbhatia commented 3 years ago

Search results should appear like this:

Desktop: Desktop

Or else show box same as before in desktop view.

Mobile: ( pretty much same as already there ) mobile

Ckbhatia commented 3 years ago

Awesome job 👍

Can you raise this PR against the feature branch? I will merge it.

marcotgs commented 3 years ago

I changed the base to feature branch.