search

Ckbhatia / Ck-gatsby-blog

A beautiful and featureful gatsby blog starter for bloggers. It is an open-source project.
https://chetanblog.netlify.com
MIT License
37 stars 33 forks source link

Fix CSS alignment of social share buttons #3

Open Ckbhatia opened 4 years ago

Ckbhatia commented 4 years ago

Fix social share alignment for following screens

  1. The social share position should not break when the article text isn't enough ( Desktop screen ).

You can refer to this for the issue or see image below: https://chetanblog.netlify.app/blog/introToGit

social_share

  1. It should not overlap the heading below it ( Mobile screen: width 414):

social_share_mobile

Note: please work on your fork with some dummy article data to reproduce the same issue on your local machine.

Please don't hesitate to ask for help if needed.

adsingh14 commented 4 years ago

I can help you with this. Just started working on it. Before starting, I have some questions:

  1. In screenshot 1, do you want to fix the position of social icons ?
  2. Are you using Chrome browser for this website ?
Ckbhatia commented 4 years ago

Hi @adsingh14

  1. I want to fix positions of social icons.
  2. Yes, these screenshots are from chrome.

Please make sure about firefox too if possible.

adsingh14 commented 4 years ago

IRT point 1. Do you want to keep the icons under stats text and on screen all the time?

No problem about firefox. I'm Firefox user.

Ckbhatia commented 4 years ago

Hello @adsingh14

Can you achieve this? ( Optional )

Author profile and social icons should be aligned well with the cover image of the article like this: tobe

adsingh14 commented 4 years ago

Yes ! Does the icons and profile side remains fix on tablets and desktop ? (Take a look at the attachment)

image

Ckbhatia commented 4 years ago

No, It is not fixed. I want you to fix like this.

Ckbhatia commented 4 years ago

@adsingh14 Are you working on this?

adsingh14 commented 4 years ago

Project isn't running on local. I've run yarn command and it stuck on step 2.

niftyrinki commented 4 years ago

@Ckbhatia Can I take this up?

Ckbhatia commented 4 years ago

@adsingh14 What is the error?

Ckbhatia commented 4 years ago

Have you followed the project setup guide?

adsingh14 commented 4 years ago

Yes. I followed up Access Locally step from guide.

adsingh14 commented 4 years ago

In the guide you've marked contentful step optional but it asks about .env.production.

Error: Failed to find .env file at path: .env.production

adsingh14 commented 4 years ago

I skip this issue from my side. I can do CSS thing but incomplete guide stops me doing this. You can assign this to anyone.

Ckbhatia commented 4 years ago

Can you please create .env.production and paste the same env variables?

Ckbhatia commented 4 years ago

@niftyrinki Have you tried to set up this project?

Ckbhatia commented 4 years ago

Please feel free to pick this issue as no one else picked it yet

sachinttn9663 commented 4 years ago

Please feel free to pick this issue as no one else picked it yet

@Ckbhatia PLease assign it to me, want to work on it.

Ckbhatia commented 4 years ago

@sachinttn9663 I am glad to see your interest to work on this issue. I will be happy to see your PR for this issue.

sachinttn9663 commented 4 years ago

@Ckbhatia , I'm getting the following error Can you please check Screenshot from 2020-10-05 13-24-07

Ckbhatia commented 4 years ago

@sachinttn9663 Please use these env variables for development.

CONTENTFUL_SPACE_ID=0dxfiyfxoovv CONTENTFUL_ACCESS_TOKEN=aQ8VH0ajavUGJur3I6LGRTZ

sachinttn9663 commented 4 years ago

Still getting error Screenshot from 2020-10-05 22-18-26

Ckbhatia commented 4 years ago

Please check your internet connectivity and try again.

This kind of error is related to internet connectivity issue.

Hackerbone commented 4 years ago

I would Like to work on this as well

Ckbhatia commented 4 years ago

@Hackerbone Please go ahead. I would love to see your PR.

Ckbhatia commented 3 years ago

Hi @Hackerbone, Do you have any updates on this issue?

If not, Can you please work on it and raise PR before the upcoming HactoberFest, So I can close issues?

Mukta-Sawant commented 3 years ago

@Ckbhatia Can I work on this as a part of Hacktoberfest 2021?

Ckbhatia commented 3 years ago

Go ahead 👍

On Fri, 1 Oct 2021 at 18:39, Mukta Sawant @.***> wrote:

@Ckbhatia https://github.com/Ckbhatia Can I work on this as a part of Hacktoberfest 2021?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Ckbhatia/Ck-gatsby-blog/issues/3#issuecomment-932213010, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2SGUKJIJUPZDQHQMG4SD3UEWXIDANCNFSM4SAT74MA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ayasahmad7655 commented 3 years ago

can I work on it as well?

ayasahmad7655 commented 3 years ago

I will improve the social bar in the mobile app.

Ckbhatia commented 3 years ago

@Mukta-Sawant Any update?

Mukta-Sawant commented 3 years ago

@Ckbhatia sir I need help in setting up the project locally.

Ckbhatia commented 3 years ago

Please check discord

On Mon, 4 Oct 2021 at 09:55, Mukta Sawant @.***> wrote:

@Ckbhatia https://github.com/Ckbhatia sir I need help in setting up the project locally.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Ckbhatia/Ck-gatsby-blog/issues/3#issuecomment-933132427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2SGUPF6FBMVSTQFRUX4ITUFEUBZANCNFSM4SAT74MA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

adsingh14 commented 3 years ago

Hi @Ckbhatia ! I would like to work on this. Shall I wait to get assigned ?

adsingh14 commented 3 years ago

image

Can you please update node-sass package? Although, terminal informed about the old npm packages are in use. image

Ckbhatia commented 3 years ago

Hi Aman,

No there's no need to wait for assigning the issue.

I will assign to you.

Yeah, you can update the package in your PR. I will accept it.

Thanks

On Sun, 10 Oct, 2021, 12:52 am Amandeep Singh, @.***> wrote:

[image: error image] https://user-images.githubusercontent.com/35252877/136671459-29a1424e-e741-45e5-bffc-b87b4f1388ed.png

Can you please update node-sass package. Although, terminal informed about the old npm packages are in use.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Ckbhatia/Ck-gatsby-blog/issues/3#issuecomment-939349753, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2SGUKIN6A2ME2XO742O5TUGCJBBANCNFSM4SAT74MA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

adsingh14 commented 3 years ago

Have you updated components\Mode.js in your system? That file also needs to update. Apart from that, I've updated the node-sass package but still getting webpack error.

Ckbhatia commented 3 years ago

No component isn't updated. I have an m1 mac. There are some dependency issues on this system. So, I need to dockerize to run it.

adsingh14 commented 3 years ago

It'd be great if you add docker commands in this repo, if that solves the issue.

Ckbhatia commented 3 years ago

On most other system, it doesn't need docker.

Erum640 commented 2 years ago

Please assign me this issue i want to work on it