search

Ckbhatia / Ck-gatsby-blog

A beautiful and featureful gatsby blog starter for bloggers. It is an open-source project.
https://chetanblog.netlify.com
MIT License
37 stars 33 forks source link

Read More Feature added #33

Closed ritikakhandelwal-17 closed 1 year ago

ritikakhandelwal-17 commented 3 years ago

The read more button will be shown if there are more articles left, if all articles are displayed it will be hidden. Please review it and tell me if any changes are needed. Issue: #13

netlify[bot] commented 3 years ago

👷 Deploy request for chetanblog accepted.

🔨 Explore the source changes: 5663b8b05f4c026724d182af02c80e01e86ca4ec

🔍 Inspect the deploy log: https://app.netlify.com/sites/chetanblog/deploys/616431fb9a5d5a0007f970ee

Ckbhatia commented 3 years ago
Screenshot 2021-10-06 at 12 17 51 PM

Great work!

Requested changes:

  1. Reduce shadow levels as per design.
  2. Add top - bottom margin.
  3. Read more text colour should be matching to design.
  4. Read more text font size should change on resizing.
  5. Read more's colours should follow dark mode.
Ckbhatia commented 3 years ago

Design: https://user-images.githubusercontent.com/37036881/95007773-0b703800-0631-11eb-8d0e-6920d717f977.png

ritikakhandelwal-17 commented 3 years ago

Screenshot (360) Screenshot (361)

@Ckbhatia is these designs fine?

Ckbhatia commented 3 years ago

Looks good

ritikakhandelwal-17 commented 3 years ago

@Ckbhatia I have done the requested changes.

Ckbhatia commented 3 years ago
Screenshot 2021-10-10 at 11 47 09 AM

More top margin required.

At least 40 pixels for mobile and 60 pixels for laptop.

ritikakhandelwal-17 commented 3 years ago
Screenshot 2021-10-10 at 11 47 09 AM

More top margin required.

At least 40 pixels for mobile and 60 pixels for laptop.

@Ckbhatia Done!

Ckbhatia commented 3 years ago

Great work!

Thanks for your contribution to this project.

It would be a great pleasure if you ⭐️ this project.

Ckbhatia commented 3 years ago

@ritikakhandelwal-17 One problem is there.

You need to raise this PR against the feature branch instead of master and also take a pull from the feature branch before a push.