Ckbhatia / Ck-gatsby-blog

A beautiful and featureful gatsby blog starter for bloggers. It is an open-source project.
https://chetanblog.netlify.com
MIT License
37 stars 33 forks source link

Fix CSS alignment of social share buttons #35

Open adsingh14 opened 2 years ago

adsingh14 commented 2 years ago

Solved Issue: #3

Description:

image

netlify[bot] commented 2 years ago

đź‘· Deploy request for chetanblog accepted.

🔨 Explore the source changes: c2935f2bf5092d5915a1f5814b6f36a85a8ca17a

🔍 Inspect the deploy log: https://app.netlify.com/sites/chetanblog/deploys/616496a7f17c8300085b0a28

Ckbhatia commented 2 years ago

You are almost there.

It should be visible with the article cover image and fixed there and should be moved when the article ends not before.

adsingh14 commented 2 years ago

You are almost there.

It should be visible with the article cover image and fixed there and should be moved when the article ends not before.

Initial: Uploading Screenshot 2021-10-11 at 9.45.36 PM.png…

Scroll: Uploading Screenshot 2021-10-11 at 9.46.08 PM.png…

End: Uploading Screenshot 2021-10-11 at 9.47.39 PM.png…

Images were not rendering.

image

Ckbhatia commented 2 years ago

Scroll End:

Scroll end
adsingh14 commented 2 years ago

Scroll End: Scroll end

Do you want to place it in bottom fixed position or bottom sticky position ?

Ckbhatia commented 2 years ago

Share initial: ( no scroll )

share-initial

Share scroll:

Screenshot 2021-10-11 at 9 56 41 PM
Ckbhatia commented 2 years ago

Check out this video: https://www.loom.com/share/b7febf41b37a44478d3887d22f43d927

adsingh14 commented 2 years ago

@Ckbhatia PR updated.

Ckbhatia commented 2 years ago

Thanks

Ckbhatia commented 2 years ago

@adsingh14 It's working for some fixed length articles only not on others. Please try to put dynamic values to positioning properties.

adsingh14 commented 2 years ago

Well, I've tested using Devtools. May I know what particular device doesn't showing it as expected?

Ckbhatia commented 2 years ago

No, it's not about any device. It has a fixed top position where it requires dynamic value as per article text, cover image and title heading.

adsingh14 commented 2 years ago

Well, I have a single blog under 'Demo' credentials. Can you add a few so I create similar cases on local ?

Ckbhatia commented 2 years ago

I will update you

On Wed, 13 Oct 2021 at 10:21 PM, Amandeep Singh @.***> wrote:

Well, I have a single blog under 'Demo' credentials. Can you add a few more so I can create that case on local ?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Ckbhatia/Ck-gatsby-blog/pull/35#issuecomment-942498653, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2SGUJIZCC7QVT3SOB6P5LUGW2IPANCNFSM5FYDFBHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

adsingh14 commented 2 years ago

I will update you …

Any update ?

Ckbhatia commented 2 years ago

Space ID: 0dxfiyfxoovv

Content Delivery API - the access token

aQ8VH0ajavUGJur3I6LGRTZvjYf25s9ILko6bgLU9z8

Content Preview API - access token

Vn3YH_guhFjM5NXkD8wfdI0YZy0os4IigbAX5mT-Go0