Open cviddy17 opened 6 years ago
ClaireBookworm
commented
6 years ago Thank you so much for your review! I was confused as what you mean when you say some errors were raised. Do you mean when you're running it or there were bad ways I wrote the code? There were so many bugs in my code with was a glass tower of text, so I'm worried something went wrong. Thank you so much!
cviddy17
commented
6 years ago Your code was written very well, but adding the user interface portion (The bonus) produced some errors. Please take the time to work through your code in the future!
On Mon, Jul 30, 2018 at 2:56 AM ClaireBookworm notifications@github.com wrote:
Thank you so much for your review! I was confused as what you mean when you say some errors were raised. Do you mean when you're running it or there were bad ways I wrote the code? There were so many bugs in my code with was a glass tower of text, so I'm worried something went wrong. Thank you so much!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ClaireBookworm/pwp-capstones/issues/1#issuecomment-408765200, or mute the thread https://github.com/notifications/unsubscribe-auth/ARbo7cqb9zI3n3Oyn__i6UUWn0ekPA6hks5uLq4GgaJpZM4Vl027 .
-- Chad A. Valencia
ὅπερ ἔδει δεῖξαι
ClaireBookworm
commented
6 years ago Well, when I runned it in Atom - it worked perfectly. I think using the while 1 loop was risky. A forever loop is never good. ;)
Rubric Score
Criteria 1: Valid Python Code
Criteria 2: Implementation of Project Requirements
Criteria 3: Software Architecture
Criteria 4: Uses Python Language Features
Criteria 5: Produces Accurate Output
Overall Score: 19/20 Exceeds Expectations
I believe that the books objects were automatically in lowercase because as implemented, they just add the book objects to the user behind the scenes. Overall you have a good understanding of what was going on, and you raised the proper questions that would help better your understanding. Great job!