search

Clam- / pyBurlyBot

IRC bort
5 stars 2 forks source link

[tell/remind] Add warning when trying to tell/remind someone many thing #29

Open Clam- opened 9 years ago

Clam- commented 9 years ago

I guess need to query for undelivered items and count. Should be trivial.

Clam- commented 9 years ago

Do we actually want this? I've put the query in the code commented out, but it seems kinda... useless? If you think otherwise you just need to uncomment the code and then throw on some extra text in the conditional. I also think it might be slow query...

gkistler commented 9 years ago

Not a big deal if it's a slow query since it'll just be on tell, but I agree that it seems kinda useless.

The message existed in oldbbm because oldbbm did fire and forget with the tells when pastebinning them, so it would be better to focus our attention on ensuring the delivery of tells instead of warning that they might get lost.

Clam- commented 9 years ago

This may be important after all since current bot will fire and forget pastehelper. Do we want to continue using pastebins for tells and stuff? Or do we want overflows to go to notices and such? (I think people like spying on tells and stuff. I know I do if I'm bored.)

gkistler commented 8 years ago

I'm thinking the best bet is to modify the database to indicate delivery after either bot.say() or pastehelper() finishes successfully; I'm giving this a try in pbm_alert.py and will implement in tell if it's coo'.

Clam- commented 8 years ago

That would be useful to rewire the logic to update the DB after paste finishes. I update the DB in the same request as getting the tells (batch) so that no weird timing double tell issues occur but maybe that can be reworked, or undoing the update on failure. https://github.com/Clam-/pyBurlyBot/blob/master/modules/pbm_tell.py#L105