Clamb94 / StableApproach

Flight data monitoring for X-Plane 11/12
39 stars 66 forks source link

Update A306_by_iniSi.sacfg #39

Closed FatihKoz closed 2 years ago

FatihKoz commented 2 years ago

There should be a space between the dataref and the minus sign, current profile creates an error. (Change must be applied to the beta branch too)

FatihKoz commented 2 years ago
23:15:28.706968 StableApproach [DEBUG] LoadFile(./Output/preferences/StableApproach/aircraftConfigs/A306_by_iniSi.sacfg)
23:15:28.716968 StableApproach [ERROR] Could not parse requirement(syntax) :16093.439453 < 5000 or
(((3048.000000 - 0) < 450)
and0.000000 >= 4)
23:15:28.730968 StableApproach [ERROR] Dataref not found (ManagedDataref):A300/FMS/vapp_speed-
23:15:28.730968 StableApproach [ERROR] Dataref not found: 'A300/FMS/vapp_speed-'

Errors caused by this profile from my X-Plane log. Both fixed with this PR

Clamb94 commented 2 years ago

Thanks for the PR. Good find. I don't want to remove all /n at the moment. Actually, some of them which have been removed are in descriptions and are intentional. Is it possible for you to modify this PR to only fix the space, nothing else? I don't think I can do that.

Thanks!

Edit: I managed to add it again myself

FatihKoz commented 2 years ago

So please let me understand, you want to keep the \n's in the check code but not in the descriptions ?

Clamb94 commented 2 years ago

No, the other way around. I want to keep them in the description. For the condition, they might be removed, but then I'll do it for all profiles at once, just for consistency.

FatihKoz commented 2 years ago

Ok, got the point ;)