Clamb94 / StableApproach

Flight data monitoring for X-Plane 11/12
39 stars 66 forks source link

Update B748_by_Super.sacfg #68

Closed FatihKoz closed 9 months ago

FatihKoz commented 9 months ago

Fixed author name (it needs a space at the end) Corrected vapp check logic, (I hope)

Clamb94 commented 9 months ago

I can't say anything about the author name, but I don't think the change you made to the vapp is not correct. The condition needs to be true if everything is correct. $SSG/B748/FMC/land_speed < 100 would be true when no approach speed has been selected.

Have you flown this AC recently and had an issue with it?

Clamb94 commented 9 months ago

I should have fixed the speedbrakes. Same issue as with the vapp. Condition needs to be true when everything is correct. (StableApproach for MSFS works the other way around)

FatihKoz commented 9 months ago

Yeah, when I used the author name without the space at the end, SA gave me an error... I would suggest having an sql LIKE style check or maybe we can trim all spaces to check, this will eliminate this kind of space based errors.

I did two flights with the aircraft (latest xp12 build), most probably my profile was overwritten and our changes were reverted back somehow, so I got speed brake false detection issue.

If you can push this to both main and beta, I can do another test (maybe today, or tomorrow after work)