ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
230 stars 404 forks source link

[BUG] Cat with both deaf and partial hearing loss permanent conditions #2345

Closed ReenieKitty closed 1 month ago

ReenieKitty commented 1 month ago

Type:

I genuinely don't know but this seemed like the closest option given an oversight in the code is a possible cause.

Describe the bug Hopefully the screenshot is pretty self explanatory, but I don't think a deaf cat should also be able to also have partial hearing loss, same for a blind cat having failing eyesight, although I haven't seen that one (I just assume it's possible considering it's a very similar scenario). Since partial hearing loss can turn into deafness, by that logic, I would think one cat shouldn't be able to be both.

Grade:

Took me a very long time to even notice so there's really no impact on anything except maybe lore.

Reproduce Steps to reproduce the behavior:

  1. Acquire a cat with the deaf permanent condition
  2. Have that cat also gain partial hearing loss (example cat had a torn ear from an enemy warrior despite always being a medicine cat and never a warrior apprentice, it was a random moonskip injury).

Commit # or Game Version Number: This was found in Lifegen but I was told it was likely a Clangen problem. Most recent version of Lifegen, not sure what version of clangen is running underneath.

Additional context I brought this up in the Lifegen server a few days ago as I wasn't sure if Lifegen had changed permanent conditions and was told this was likely a vanilla Clangen thing, but now that I've created an account here I figured I would make a report since I can't find one if one was opened for me.

I did some testing by setting the probability of the partial hearing loss progressing to a second instance of deafness from 80 to 2 (after inquiring is a lower number means higher or lower chances and was told 80 meant 1/80, 2 would be 1/2), and nothing happened after skipping 20 moons. I then changed it to 1, just to see what would happen. After that failed, I edited her conditions file to replace the partial hearing loss with deaf, and it wiped her permanent conditions in game. File was intact, but no permanent conditions displayed in the game itself. That was easily fixed by replacing the second deaf with partial hearing loss again. I don't think it's actually possible to get a double deaf cat, but I still don't think the overlap should be possible.

Screenshots Screenshot (467)