search

ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
251 stars 450 forks source link

Create a pull request template #2379

Closed Thlumyn closed 4 months ago

Thlumyn commented 4 months ago

Adds a template for pull requests

This means that when people create a pull request, the description section comes pre-filled with some headers and comments.

Thlumyn commented 4 months ago

@scribblecrumb I made those changes; the idea was for each PR to have EITHER the "why it's good" section or the "linked issues" section. But I don't think it's the end of the world if the rare bugfix goes through that has neither section as long as it has the summary and proof of testing

scribblecrumb commented 4 months ago

I agree! I think it's rare we have someone make a bugfix without there being an issue report about it first anyways. Like you said, as long as they're summarizing and displaying proof of testing, it should be fine.

scribblecrumb commented 4 months ago

Oh! Sorry, just had another thought. Do we want to add a note about proper PR titling? (i.e. using Content, Feature, Bugfix; and giving a short, but descriptive title)

Thlumyn commented 4 months ago

@scribblecrumb How is that?

scribblecrumb commented 4 months ago

@Thlumyn Looks good!