Bug fix. Fixes #2275 - Githubissues

ClanGenOfficial / clangen

Warrior Cats fan game

https://clangen.io

Other

229 stars 403 forks source link

Bug fix. Fixes #2275 #2393

Closed susieoneil closed 3 weeks ago

susieoneil commented 1 month ago

About The Pull Request

Modified reveal_murder in History class to record the current moon. Added a new revelation_moon key to both murderer and victim history dictionaries.
Modified get_murder_text and get_text_for_murder_event in ProfileScreen to add revelation_moon to both murderer and victim histories.
Minor adjustments to variable names, line lengths, comments, etc.

Linked Issues

Fixes: #2275

Proof of Testing

Followed the same steps from the issue:

skip moons till a cat kills another
skip moons till its found out
turn on "show moons" in the killer's history.

Murderer history murder-history

Victim history victim-history

scribblecrumb commented 3 weeks ago

Looks like there's some failing tests to address before we can review this

susieoneil commented 3 weeks ago

Fixed the conflicts, tests are passing, ready for review. @scribblecrumb