ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
251 stars 450 forks source link

Random Clan Quick Start #2399

Closed kainosaur closed 3 months ago

kainosaur commented 4 months ago

About The Pull Request

This pr is for a setting in clan creation to have your clan quickly generated for you. After picking your gamemode, the option for the player to generate a quick and random clan will show up.

Why This Is Good For ClanGen

Gets you into the game quicker if you so choose.

Linked Issues

This was inspired by issue #1881 , with the idea of trying to get into the game faster

Proof of Testing

https://github.com/ClanGenOfficial/clangen/assets/152326772/aadd0deb-969d-47c6-a5fa-3d74816b4574

Changelog/Credits

add random clans for startup

scribblecrumb commented 3 months ago

I like the look of this! On the UI side though, I'd prefer if we weren't interrupting the "normal" clan creation experience with the question/confirmation screen. I think it'd be nicer to add a checkbox toggle to the game mode selection screen instead, perhaps right above the prev/next buttons. You could label it as "Quick Start", have it toggled off automatically, and include a tooltip with a longer explanation (clan will be entirely randomized, season will be newleaf). If you'd like an additional confirmation from the user, then you could have a popup appear upon clicking next (if the Quick Start is toggled on) asking if the user is certain of their choice. But, I don't think that's particularly necessary in this case, since it's easy enough to just back out of the Clan and make a new one if you do accidentally have Quick Start toggled.

kainosaur commented 3 months ago

Ok I'll try to make that! I'm not the best at ui though so it might not look very pretty

kainosaur commented 3 months ago

Checkbox completed. Text is higher than it should be though.

https://github.com/ClanGenOfficial/clangen/assets/152326772/69f86328-fa42-44e3-b115-75cec3d39a4c