ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
251 stars 450 forks source link

[CODE] issue with kittypets added from patrols #2404

Closed stxrrydream closed 3 months ago

stxrrydream commented 3 months ago

Type: Code

Describe the bug When a kittypet from patrol joins the clan, clicking on it from the cat list menu brings me to another cat's page. Cat's page can only be accessed through medicine den. One of the cats' history says that they were mentored by another cat in the clan (and the other cats' history says they mentored the kittypet) despite the cat joining as a 200+ moon senior. Both cats disappeared from my clan after saving, quitting, and reopening. They don't seem to be in the clan cats .json, even before closing the game.

Grade: Important(?)

Reproduce Steps to reproduce the behavior:

  1. Go to patrols
  2. Border patrol until you get gen_bord_abandonedkittypet1_kittypet4 (there was another border patrol where I found a sick kittypet by the thunderpath but I couldn't find the patrol id for it)
  3. Proceed, get successful outcome, try to click on cat on cat list, check history, save and close game.
  4. When clicked on in the cat list, a different cat page's will open. Cat will disappear from clan entirely if the game is closed.

Patrol ID + Outcome Print (if applicable): PATROL START --------------------------------------------------- Patrol Leader: Silentstar Random Cat: Moreltuft Total Number of Possible Patrols | normal: 9, romantic: 0 starting chance: 30 | EX_updated chance: 75 Moreltuft updated chance to 75 | Silentstar updated chance to 75 | Rubblevalley updated chance to 75 | PATROL ID: gen_bord_abandonedkittypet1_kittypet4 | SUCCESS: True PATROL END -----------------------------------------------------

Commit # or Game Version Number: https://github.com/ClanGenOfficial/clangen/commit/85dd91978514e159aeec40974b0e392def34d6e9

Additional context The cat it says Tonka (missing kittypet #2) was mentored by (Skyclaw) actually mentored Rubblevalley, the cat whose page opens instead of Tonka or Thoko (missing kittypet #1). (i found something new while playing that might add more context and thought i should edit this instead of making a new one or commenting? let me know if that's wrong <3) I had an apprentice from another clan join, and their history seemed to be from Rubblevalley? Clicking on Rubblevalley also brings me to his page, but not the other way around. He was still there after a moon skip and after I saved, exited, and reopened the clan. Upon reloading the game, he seems to have a correct history and the looping "next/previous cat" seems to have fixed.

Screenshots

thoko error 1

Screen_Recording_2024-06-06_at_7 47 00_PM-ezgif com-video-to-gif-converter

tonka 1 tonka 2 tonka 3 tonka 4

Screen_Recording_2024-06-06_at_7 57 35_PM-ezgif com-video-to-gif-converter

Screen Shot 2024-06-06 at 9 38 20 PM Screen Shot 2024-06-06 at 9 38 48 PM

ScreenRecording2024-06-06at9 41 09PM-ezgif com-video-to-gif-converter