[CLEANUP] Status to Enum

j-gynn commented 3 weeks ago

About The Pull Request

I'm back at it again. This time, I'm doing some work in cats.py, lifting out some of the frequently-accessed things and making them not be strings. This flavour is status! Part of #2436

Blockers

[x] Blocked by #2264 (no code shared, I just wanna get that in first before this haha)

Changes

[x] Convert status to enum
[x] (?) Consider whether to set as property of Cat & migrate status_change to @status.setter

Why This Is Good For ClanGen

Happy code, happy devs. Happy devs, happy life. Better internal structures make it easier to make better stuff quicker.

Proof of Testing

This will require HEAVY testing. I am basically smashing the codebase with a hammer. Along the way I have been making tests to ensure things do what they're supposed to, but I will need lots of help from beta testers to make sure things don't slip through the cracks.

Have written some supporting tests, but if there's any feedback and/or missing tests to integrate, let me know.

Link to testing thread on Discord

Changelog/Credits

Internal cleanup & revisions

j-gynn commented 3 weeks ago

Okaaaay... can someone take a look and help me figure out why freshkill_test is failing here? It passes on my local machine (no uncommited/unpushed changes either)

j-gynn commented 3 weeks ago

Ready for review! At this point, I think I have to ignore freshkill_test, because it straight-up chooses when to work. I can rerun it until it passes if you want proof, but...

j-gynn commented 1 week ago

A few bugs have been found so temporarily putting this back to draft

ClanGenOfficial / clangen