ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
229 stars 403 forks source link

[CODE] Refactor ceremonies #2427

Open scribblecrumb opened 3 weeks ago

scribblecrumb commented 3 weeks ago

Description Moon ceremony events are currently handled separately from ShortEvents. They've grown to a point of being complex enough that I believe they would benefit from a more structured format, rather than the tag spaghetti they currently rely on. I think they would mesh well with the new ShortEvent format and could likely be handled as ShortEvents. They would probably need to be a new type of ShortEvent (so adding a "ceremony" type alongside the current "death", "misc", "new_cat", and "injury"). ShortEvent format documentation is found in our wiki docs.

Deputy and Leader ceremonies are also currently handled separate from all the other ceremonies. I would prefer if they were all handled together (or at least, more clearly intertwined) as the current iteration is rather confusing to navigate. Note: Leader StarClan ceremonies are entirely separate and shouldn't be included here, I'm specifically talking about the Leader moon ceremonies.