search

ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
229 stars 403 forks source link

Bugfix: The entire clan is no longer poisoned by gen_hunt_strangerabbit1 #2434

Closed j-gynn closed 3 weeks ago

j-gynn commented 3 weeks ago

About The Pull Request

A possibly-stopgap fix to stop the entire Clan being poisoned by the strangerabbit1 fail event by removing the some_clan tag.

Currently, some_clan and clan have the exact same backend code. I don't know what the intended outcome for some_clan is, if it's not this behaviour. It appears to be an undocumented abbreviation? What is its intended behaviour?

Linked Issues

Fixes #2432

Proof of Testing

image image (the story specifically requests that r_c is affected, meaning the minimum number of affected cats is 2)

Changelog/Credits

scribblecrumb commented 3 weeks ago

Intended behavior is close to what you suggested, honestly. It's essentially that "some" of the cats in the clan get affected, and that those cats are just chosen randomly. I'm surprised I didn't notice that it wasn't working when I did the refactor haha.

Frankly, it wouldn't be bad for us to split the "some_clan" tag into more specific options (ala the supply reduce tags, maybe? so "clan_eighth", "clan_fourth", "clan_half". and then affect that given fraction of the clan). As right now it's not super useful for a wide range of things of situations. However, it's OG intent was literally just to allow this specific patrol to poison a random selection of clanmates, so for now we can just tailor it's effect to that intent. I think bringing your suggested implementation down to selecting 1/8th of the cats in the clan, rather than 1/4, would be closer to the intended effect for that patrol.

j-gynn commented 3 weeks ago

Like this?

scribblecrumb commented 3 weeks ago

Looks good! Add a proof of testing and I'll get this approved.

j-gynn commented 3 weeks ago

Looks good! Add a proof of testing and I'll get this approved.

Done :)