ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
229 stars 403 forks source link

[PROJECT] `Cat` Class Rework #2436

Open j-gynn opened 3 weeks ago

j-gynn commented 3 weeks ago

Description This involves a rework of Cat. At present, related data is entirely disparate, str is pretty much the de-facto variable type, there are so, so many interconnected dependencies that it kind of hurts my soul, testing the cat itself is really difficult...

Scope of Project Please choose from following list, feel free to give further details:

This is huge. I will be doing this in separate PRs, because I'm not a madman. Ideally, I'd like to have __init__ have a MAXIMUM of 5-7 inputs, but I think that's a pipe dream. The current proposal would have 11, for perspective. I don't need help with this project, I just need to put it somewhere so that everyone can keep track of the proposed changes, what's already implemented and the future of Cat.

What this is NOT:

Checkmark: merged into development.

Major Changes Summarised

Existing variable changes

DELETIONS

Type changes

Name changes

Classes (grouping similar information together for clarity - and getting it out of cats.py!)

Not sure about

Delete entirely

j-gynn commented 2 weeks ago

/assign-me

github-actions[bot] commented 2 weeks ago

👋 Hey @j-gynn, thanks for your interest in this issue! 🎉

⚠ Note that this issue will become unassigned if it isn't closed within 7 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.