ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
229 stars 403 forks source link

[BUG] Non-unique event IDs #2442

Closed j-gynn closed 2 weeks ago

j-gynn commented 3 weeks ago

Type: (only select one)

Describe the bug During the course of developing a handy little tool for y'all, I've found that the following IDs are not unique:

gen_death_war_any3
gen_death_ockill_anymed1
gen_death_rogue_any1
gen_death_badprey_any1
gen_death_bury_multi1
multi_injury_anykit1
multi_injury_anybruises1
gen_injury_clawwoundcatbite_anyapprenticemultitraitappmentorothercat1
gen_injury_clawwoundcatbite_anyapprenticemultitraitappmentorothercat1 (yes, there are 3 of these)
gen_misc_freshkill_anystolen1
gen_misc_herb_anyallyrequeslungwort2
gen_new_cat_war_any2

This is across the entire event ecosystem (* new moonskip layout only). If we are permitting duplicates in different files, may I politely suggest that we... don't? I haven't tested as I'm working on the tool - just enough to ensure it hasn't lied to me about the dupes!

Grade: (only select one)

Reproduce Steps to reproduce the behavior:

  1. Search for the associated IDs
  2. There are many.

Patrol ID + Outcome Print (if applicable): see above

Commit # or Game Version Number: development