search

ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
229 stars 403 forks source link

[BUG]Wrong Secret Murderer Listed #2446

Closed thunderingboom closed 2 weeks ago

thunderingboom commented 3 weeks ago

Type: UI Describe the bug Had a moon event where there was a secret murder, went to look at the history and it listed that the cat was secretly murdered by themselves and not the actual killer. Don't know if this information is helpful, but the particular cat murdered had been invited into the clan moons earlier via the leader den.

Grade: (only select one) Regular

Reproduce Steps to reproduce the behavior:

  1. Get a moon event of a secret murder.
  2. Look at history of murdered cat.

Commit # or Game Version Number: 6c5f99b5

Screenshots 2024-06-12 (1)

j-gynn commented 2 weeks ago

/assign-me

github-actions[bot] commented 2 weeks ago

👋 Hey @j-gynn, thanks for your interest in this issue! 🎉

âš  Note that this issue will become unassigned if it isn't closed within 7 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.

j-gynn commented 2 weeks ago

So far, I've tracked it down to moonskip event murder generation - it looks like the victim is being hardcoded in as the killer on the text before it is then saved to their .json. Will continue to investigate.

j-gynn commented 2 weeks ago

Found it. death_history is run through history_text_adjust, which is expecting m_c to be describing the cat whose history we are looking at... but in murder histories, m_c is the murderer. Now to wait until I can get a murder to happen to check I've fixed it...