Assigning status via __init__ has unexpected effects vs assigning later

[j-gynn]

Type: (only select one)

• Code - general bugs related to how the game runs and responds to you.

Describe the bug Good luck to thee that takes this on. I have first noticed it in freshkill_test, so it may be a freshkill quirk, but it may also be a Cat problem. Basically, sort order becomes arbitrary when an otherwise-blank Cat is initialised with a status, and I have no idea why.

Grade: (only select one)

• Non-vital - This bug can easily be ignored and does not have a large impact on play

Reproduce Steps to reproduce the behavior:

1. Go to the freshkill tests
2. move status="warrior" into Cat()`
3. Watch tests fail 1/3 of the time
4. (optional) cry

Commit # or Game Version Number: Development

Additional context Add any other context about the problem here.

Screenshots

[larkgz]

/assign-me

[github-actions[bot]]

👋 Hey @larkgz, thanks for your interest in this issue! 🎉

⚠ Note that this issue will become unassigned if it isn't closed within 7 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.

[larkgz]

The default status for cats in __init__ is newborn. Therefore the cats have the age of a newborn in the original test. Newborns are always fed first according to feeding order. If you set the moons the same (specifying just status='warrior' gives you a random age between young adult and senior adult which are fed in a different order because they're auto-sorted by moons), then the tests pass again.

[j-gynn]

Ah, so it's the assignation of moons that causes the problem... I should probably have clocked that. Still, it's not an expected outcome for status and moons to be linked together in init to the end user. I've specified status, not age - and definitely not moons. It should probably be changed imo, but I'm no senior dev haha.

[larkgz]

Unassigning myself as it seems to require a larger change and I don’t think it’s a bug. Could maybe resolve with #2436 in the future.