ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
249 stars 448 forks source link

[CODE] History Tweaks #2467

Open scribblecrumb opened 3 months ago

scribblecrumb commented 3 months ago

Description An issue we currently have with History is the assigning and preservation of cat names. At the moment it's a rather convoluted system (that doesn't work well) due to the breadth of cat name abbreviations we have across the game. We cannot simply replace the names at the time of history creation and be done with it, because we want the names to be capable of changing if a cat's name is changed in game, rather than simply being static. Not to mention that, with the addition of the pronoun update, we don't want to be misgendering a cat within old history text.

Thus comes the question of how to standardize this preservation of the cat abbrs and pronoun tags within history text. I propose replacing the cat abbreviations with the ID number of the cat. This makes recall much much simpler. We already save the IDs of the cats within the history dicts.

I would imagine this change would look like adjusting the text from: m_c died when {PRONOUN/m_c/subject} fell out a tree. to: {34} died when {PRONOUN/34/subject) fell out of a tree. or something to that affect.

We would need to keep in mind how to convert the old history saves into this new system, but I do think it would make things substantially easier to manage. We're already struggling to manage ShortEvent histories that include two cats at once, I can only imagine it will get messier and messier in the future.