[PROJECT] Sprites proposal

[j-gynn]

Description This is relatively minor as far as "refactors j-gynn has got involved in" go. Since there are now multiple things pulling from sprites.Sprites (clan sprites and cat sprites), I would like to propose a base class Sprite and subclasses CatSprite and ClanSprite that inherit from it.

Scope of Project

• Medium-sized Project (a new feature that is on the smaller size)

Outline

• Sprite (base class)
  • Variables: size, images, sprites, blank_sprite , spritesheets
  • __init__
  • spritesheet
  • make_group
• CatSprite (inherit from Sprite)
  • Variables: (all from Sprite, plus:) cat_tints, white_patches_tints
  • __init__ (with super init)
  • load_tints
  • load_all
  • load_scars
• ClanSprite (inherit from Sprite)
  • Variables (all from Sprite, plus:) symbol_dict, clan_symbols (investigate to see if should/could be refactored to use base sprites variable)
  • __init__ (with super init)
  • load_symbols

Relevant Links Is there a draft PR already made? Is there a forum post for it? Link them here.

[scribblecrumb]

I would love this! I didn't particularly like putting the clan symbols in with all the cat sprite code lol, but it was convenient at the time. I think a base class to inherit from would clean things up immensely. Definitely have my approval to work on this!

[j-gynn]

/assign-me

[github-actions[bot]]

👋 Hey @j-gynn, thanks for your interest in this issue! 🎉

⚠ Note that this issue will become unassigned if it isn't closed within 7 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.