Clan is now three separate classes: BaseClan, PlayerClan and OtherClan, each in their own file in a new directory, scripts/clan.
PlayerClan and OtherClan inherit from BaseClan.
StarClan has been deleted as it doesn't actually do anything.
seasons variable renamed to SEASONS as it is a "constant".
Removed the CAT_TYPES variable as it is dead and has no references.
Why This Is Good For ClanGen
Say it with me, gang. Happy devs... happy life. Separating the domains like this means that less dependencies are ensnared amongst each other, making it easier to not have things like the clan_class variable, which I will eradicate. Just not in this PR. I wanted to try doing a "smaller" change to make it easier to review & test.
Linked Issues
Tangentially related to #2436 but mostly as a result of trying to write unit tests for murders and attempting to scaffold the clan that way.
About The Pull Request
scripts/clan.seasonsvariable renamed toSEASONSas it is a "constant".CAT_TYPESvariable as it is dead and has no references.Why This Is Good For ClanGen
Say it with me, gang. Happy devs... happy life. Separating the domains like this means that less dependencies are ensnared amongst each other, making it easier to not have things like the
clan_classvariable, which I will eradicate. Just not in this PR. I wanted to try doing a "smaller" change to make it easier to review & test.Linked Issues
Tangentially related to #2436 but mostly as a result of trying to write unit tests for murders and attempting to scaffold the clan that way.
Proof of Testing
https://github.com/ClanGenOfficial/clangen/assets/48025294/549979a9-e5d8-4de7-9b76-4c54c560f578
Changelog/Credits